This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14692 - Updating textarea placeholder structure #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
added
2: Dev Review
enahum
approved these changes
Mar 27, 2019
hmhealey
suggested changes
Mar 28, 2019
|
@hmhealey Have a look. I still can't reproduce the RHS issue you're talking about though. |
|
Looks good to me. I think the changes to move the logic that shows/hides the placeholder to the render function fixed the issue I saw in the RHS. I think the RHS isn't having an update trigger when it first opens, and since it was checking if the placeholder should be visible on update, that's why I saw that issue |
hmhealey
approved these changes
Mar 29, 2019
hmhealey
added
4: Reviews Complete
hmhealey
pushed a commit
that referenced
this pull request
Mar 29, 2019
hmhealey
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
* MM-14692 - Updating textarea placeholder structure * Updating tests * Updating textarea changes * Updating placeholder * Updating tests
mkraft
reviewed
Apr 1, 2019
| @@ -149,4 +160,5 @@ export default class AutosizeTextarea extends React.Component { | |||
| const style = { | |||
| container: {height: 0, overflow: 'hidden'}, | |||
| reference: {height: 'auto', width: '100%'}, | |||
| placeholder: {overflow: 'hidden', textOverflow: 'ellipsis', opacity: 0.5, 'pointer-events': 'none', position: 'absolute', 'white-space': 'nowrap'}, | |||
There was a problem hiding this comment.
@asaadmahmood This is causing JS errors because this is JSX so pointer-events and white-space need to be pointerEvents and whiteSpace.
thekiiingbob
pushed a commit
to thekiiingbob/mattermost-webapp
that referenced
this pull request
Apr 2, 2019
* MM-14692 - Updating textarea placeholder structure * Updating tests * Updating textarea changes * Updating placeholder * Updating tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-14692 - Updating textarea placeholder structure
Ticket Link
https://mattermost.atlassian.net/browse/MM-14692