This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Revert "MM-14489 Making SuggestionList component render at bottom of input on dialogs (#2235)" #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
added
2: Dev Review
|
FYI @jasonblais @avasconcelos114 we'll need to reopen https://mattermost.atlassian.net/browse/MM-14489 and take another look at it |
enahum
approved these changes
Mar 31, 2019
jwilander
added
4: Reviews Complete
jwilander
added a commit
that referenced
this pull request
Mar 31, 2019
jwilander
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
thekiiingbob
pushed a commit
to thekiiingbob/mattermost-webapp
that referenced
this pull request
Apr 2, 2019
…input on dialogs (mattermost#2235)" (mattermost#2559) This reverts commit ab31a59.
lindy65
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit ab31a59 (#2235) as it breaks both the channel switcher and other usages of the suggestion box.
See: