Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14778 - Updating menu functionality #2568

Merged
merged 3 commits into from
Apr 2, 2019
Merged

MM-14778 - Updating menu functionality #2568

merged 3 commits into from
Apr 2, 2019

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-14778 - Updating menu functionality

Ticket Link

https://mattermost.atlassian.net/browse/MM-14778

@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 29, 2019
@asaadmahmood asaadmahmood added this to the v5.10.0 milestone Mar 29, 2019
crspeller
crspeller approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a snapshot update.

@asaadmahmood
Copy link
Contributor Author

@crspeller Done.

@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 1, 2019
@hanzei hanzei merged commit bc37cfe into mattermost:master Apr 2, 2019
hanzei pushed a commit that referenced this pull request Apr 2, 2019
@asaadmahmood @hanzei
MM-14778 - Updating menu functionality (#2568)
9254299
@hanzei hanzei added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 2, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 2, 2019
@asaadmahmood asaadmahmood deleted the MM-14778 branch April 12, 2019 13:01
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enahum enahum enahum approved these changes

@crspeller crspeller crspeller approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@asaadmahmood @crspeller @enahum @lindy65 @hanzei @amyblais