Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14762 Fix hover effect causing post jiggle when zoomed #2571

Merged
merged 1 commit into from
Mar 29, 2019
Merged

MM-14762 Fix hover effect causing post jiggle when zoomed #2571

merged 1 commit into from
Mar 29, 2019

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Mar 29, 2019

Summary

Will pass a class name to the DynamicSizeList to prevent a measureItem calculation when hovering to show the post options causing the posts not to jiggle.

Ticket Link

https://mattermost.atlassian.net/browse/MM-14762

Related Pull Requests

  • Has server changes (please link here)
  • Has redux changes (please link here)
  • Has mobile changes (please link here)

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 29, 2019
@enahum enahum added this to the v5.10.0 milestone Mar 29, 2019
@enahum enahum requested a review from sudheerDev March 29, 2019 19:42
@enahum enahum removed the 2: Dev Review Requires review by a core commiter label Mar 29, 2019
@enahum enahum merged commit e4c96ef into master Mar 29, 2019
@enahum enahum deleted the MM-14762 branch March 29, 2019 19:57
enahum added a commit that referenced this pull request Mar 29, 2019
@enahum
MM-14762 Fix hover effect causing post jiggle when zoomed (#2571)
e3e2625
@enahum enahum added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 29, 2019
stevepartridge pushed a commit to stevepartridge/mattermost-webapp that referenced this pull request Mar 30, 2019
@enahum @stevepartridge
MM-14762 Fix hover effect causing post jiggle when zoomed (mattermost…
af531e3 
…#2571)
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 1, 2019
thekiiingbob pushed a commit to thekiiingbob/mattermost-webapp that referenced this pull request Apr 2, 2019
@enahum @thekiiingbob
MM-14762 Fix hover effect causing post jiggle when zoomed (mattermost…
4cfb30e 
…#2571)
@sudheerDev sudheerDev mentioned this pull request Apr 5, 2019
Merged
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sudheerDev sudheerDev sudheerDev approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@enahum @sudheerDev @lindy65 @amyblais