Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14783: Fix button in progress text in add users to channel/team. #2579

Merged
merged 2 commits into from
Apr 1, 2019
Merged

MM-14783: Fix button in progress text in add users to channel/team. #2579

merged 2 commits into from
Apr 1, 2019

Conversation

grundleborg
Copy link
Contributor

Summary

While request is in progress, show "Adding..." text on "Add" buttons, rather than "Saving..." in Add User to Team/Channel modals.

Ticket Link

https://mattermost.atlassian.net/browse/MM-14783

@grundleborg grundleborg added the 2: Dev Review Requires review by a core commiter label Apr 1, 2019
@grundleborg grundleborg added this to the v5.10.0 milestone Apr 1, 2019
@grundleborg grundleborg added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Apr 1, 2019
mgdelacroix
mgdelacroix approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 1, 2019
@grundleborg grundleborg merged commit d4e422d into mattermost:master Apr 1, 2019
grundleborg added a commit that referenced this pull request Apr 1, 2019
@grundleborg
MM-14783: Fix button in progress text in add users to channel/team. (#…
d2b8a30 
…2579)

* MM-14783: Fix button in progress text in add users to channel/team.

* Fix snapshot tests.
@grundleborg grundleborg added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed 4: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 1, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 1, 2019
thekiiingbob pushed a commit to thekiiingbob/mattermost-webapp that referenced this pull request Apr 2, 2019
@grundleborg @thekiiingbob
MM-14783: Fix button in progress text in add users to channel/team. (m…
78e51f6 
…attermost#2579)

* MM-14783: Fix button in progress text in add users to channel/team.

* Fix snapshot tests.
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sudheerDev sudheerDev sudheerDev approved these changes

@mgdelacroix mgdelacroix mgdelacroix approved these changes

Assignees

@grundleborg grundleborg

Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@grundleborg @mgdelacroix @sudheerDev @lindy65 @amyblais