This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM 14801] Don't highlight [at]channel/all/here in usernames #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure (at)channel/all/here only highlight if they are distinct words
deanwhillier
added
2: Dev Review
migbot
approved these changes
Apr 3, 2019
hmhealey
approved these changes
Apr 4, 2019
hmhealey
added
4: Reviews Complete
deanwhillier
added a commit
that referenced
this pull request
Apr 4, 2019
* fix `all` highlighting in usernames make sure (at)channel/all/here only highlight if they are distinct words * remove tests that don’t work anymore
deanwhillier
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
deanwhillier
added a commit
that referenced
this pull request
Apr 11, 2019
* fix `all` highlighting in usernames make sure (at)channel/all/here only highlight if they are distinct words * remove tests that don’t work anymore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR 2338 made [at]all/channel/here mentions more flexible to allow for trailing punctuation. The fix was a bit too flexible, for example incorrectly highlighting
[at]allin usernames like[at]allen, so this PR changes the highlight behaviour to require that [at]all/channel/here mentions be distinct words preventing them from highlighting when at the beginning of a larger word like a username.Note: Since an underscore is not considered to be punctuation by regular expressions, if it is included immediately following an [at]channel/all/here mention, the mention won't highlight. This can't be easily fixed and would require more mana to attempt.
Ticket Link
MM-14801