This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fixing MM-14886 without moving back the input inside the menu #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
jwilander
reviewed
Apr 4, 2019
| @@ -2041,5 +2041,5 @@ | |||
| position: absolute; | |||
| right: 0; | |||
| top: 0; | |||
| width: 100%; | |||
| width: 0; | |||
There was a problem hiding this comment.
Would using visibility: hidden make more sense? Or does that have other effects that cause problems here?
https://developer.mozilla.org/en-US/docs/Web/CSS/visibility
There was a problem hiding this comment.
Yes, I don't trust too much in this kind of things because some browsers doesn't allow you to interact with not-visible elements, but yes, we can try with other approaches, anyway we need to test it in all the browsers (my solution works in firefox and chromium for sure)
There was a problem hiding this comment.
I'm not opposed to using width: 0 I just have the same concern that I'm not sure how all browsers will treat that and if it would still be possible to click or see somehow. I'm 0/5
jwilander
approved these changes
Apr 4, 2019
cpanato
approved these changes
Apr 6, 2019
jespino
added
CherryPick/Approved
jespino
force-pushed
the
putting-input-out-again
branch
from
4fd2187 to
3adc738
Compare
cpanato
added
4: Reviews Complete
cpanato
pushed a commit
that referenced
this pull request
Apr 6, 2019
|
cherry picked e61f79a into release 5.10 branch |
cpanato
added
CherryPick/Done
lindy65
added
Tests/Done
amyblais
added
Changelog/Not Needed
jwilander
added a commit
that referenced
this pull request
Apr 16, 2019
TranMacTien
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Jun 13, 2019
…most#2616) * Revert "MM-14886 Move file input back to be child of button (mattermost#2614)" This reverts commit 50c7ae2. * Fixing original bug without the need of moving the input inside again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem was the menu being invisible but on top of the arrow button, now is just width 0.
Ticket
MM-14920