This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Fixing remove list/join public/private teams on save permission in the admin console #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
added
2: Dev Review
mkraft
approved these changes
Apr 5, 2019
grundleborg
approved these changes
Apr 8, 2019
grundleborg
added
4: Reviews Complete
jespino
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
TranMacTien
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixed a problem updating list/join public/private teams on the interface. Before this PR the permissions were filtered during the distribution to the different roles (based on the scope) to save it.
Ticket Link
MM-14894