Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14943: Improve descriptions of emojis permissions #2618

Merged
merged 3 commits into from
Apr 8, 2019
Merged

MM-14943: Improve descriptions of emojis permissions #2618

merged 3 commits into from
Apr 8, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Apr 5, 2019

Summary

Improve descriptions of emojis permissions

Ticket Link

MM-14943

@jespino jespino added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 5, 2019
wiersgallak
wiersgallak approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!

@amyblais amyblais added this to the v5.10.0 milestone Apr 5, 2019
mgdelacroix
mgdelacroix approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkraft
mkraft approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@mkraft mkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some 0/5 opinions about making the sentences more complete.

i18n/en.json Outdated Show resolved Hide resolved
i18n/en.json Outdated Show resolved Hide resolved
mkraft and others added 2 commits April 8, 2019 22:05
@mkraft @jespino
Update i18n/en.json
9d65ef1 
Co-Authored-By: jespino <jespinog@gmail.com>
@mkraft @jespino
Update i18n/en.json
2d54525 
Co-Authored-By: jespino <jespinog@gmail.com>
@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter labels Apr 8, 2019
@jespino jespino merged commit 5018166 into mattermost:master Apr 8, 2019
@jespino jespino deleted the MM-14943 branch April 8, 2019 20:28
jespino added a commit that referenced this pull request Apr 8, 2019
@jespino
MM-14943: Improve descriptions of emojis permissions (#2618)
1f547d7 
* MM-14943: Improve descriptions of emojis permissions

* Update i18n/en.json

Co-Authored-By: jespino <jespinog@gmail.com>

* Update i18n/en.json

Co-Authored-By: jespino <jespinog@gmail.com>
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 8, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 9, 2019
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Apr 11, 2019
TranMacTien pushed a commit to Designveloper/mattermost-webapp that referenced this pull request Jun 13, 2019
@jespino @TranMacTien
MM-14943: Improve descriptions of emojis permissions (mattermost#2618)
e0c1c18 
* MM-14943: Improve descriptions of emojis permissions

* Update i18n/en.json

Co-Authored-By: jespino <jespinog@gmail.com>

* Update i18n/en.json

Co-Authored-By: jespino <jespinog@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wiersgallak wiersgallak wiersgallak approved these changes

@mkraft mkraft mkraft approved these changes

@mgdelacroix mgdelacroix mgdelacroix approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jespino @mgdelacroix @mkraft @wiersgallak @amyblais @DHaussermann