Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-14881] Migrates getSuggestion functions to mattermost-redux #2623

Merged
merged 2 commits into from
Apr 8, 2019
Merged

[MM-14881] Migrates getSuggestion functions to mattermost-redux #2623

merged 2 commits into from
Apr 8, 2019

Conversation

mgdelacroix
Copy link
Member

Summary

Removes the getSuggestions functions and imports them from mattermost-redux.

Ticket Link

MM-14881

Related Pull Requests

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core commiter Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Work in Progress Not yet ready for review CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 8, 2019
@mgdelacroix mgdelacroix added this to the v5.10.0 milestone Apr 8, 2019
@mgdelacroix mgdelacroix removed the Work in Progress Not yet ready for review label Apr 8, 2019
jespino
jespino approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grundleborg grundleborg added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 8, 2019
@mgdelacroix mgdelacroix merged commit e9beb29 into mattermost:master Apr 8, 2019
@mgdelacroix mgdelacroix removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Apr 8, 2019
mgdelacroix added a commit that referenced this pull request Apr 9, 2019
@mgdelacroix
[MM-14881] Migrates getSuggestion functions to mattermost-redux (#2623)
822e174 
* [MM-14881] Migrates getSuggestion functions to mattermost-redux

* Update refs to mattermost-redux version
@mgdelacroix mgdelacroix added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 9, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 9, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 12, 2019
bradjcoughlin pushed a commit to bradjcoughlin/mattermost-webapp that referenced this pull request Apr 15, 2019
@mgdelacroix @bradjcoughlin
[MM-14881] Migrates getSuggestion functions to mattermost-redux (matt…
1d28fdc 
…ermost#2623)

* [MM-14881] Migrates getSuggestion functions to mattermost-redux

* Update refs to mattermost-redux version
TranMacTien pushed a commit to Designveloper/mattermost-webapp that referenced this pull request Jun 13, 2019
@mgdelacroix @TranMacTien
[MM-14881] Migrates getSuggestion functions to mattermost-redux (matt…
6fe028a 
…ermost#2623)

* [MM-14881] Migrates getSuggestion functions to mattermost-redux

* Update refs to mattermost-redux version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grundleborg grundleborg grundleborg approved these changes

@jespino jespino jespino approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mgdelacroix @jespino @grundleborg @lindy65 @amyblais