-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-15039] Revert react-redux to 5.1.1 fixing the issue mostly on profile pop-over and edit channel header components #2636
[MM-15039] Revert react-redux to 5.1.1 fixing the issue mostly on profile pop-over and edit channel header components #2636
Conversation
…er and edit channel header components.
Saturnino why not upgrading the react-bootstrap library instead? |
I did try but it's giving me another set of errors. Besides, it's still in beta - 1.0.0-beta.6. I don't know if we want that. The last stable version is the one we have right now - 0.32.4. |
I think we should move fwd instead of backwards. Having said that I’ll approve just because of the beta version BUT I want to ensure that there is a follow up ticket for this. |
@enahum I agree. Ticket filed - https://mattermost.atlassian.net/browse/MM-15040 |
@saturninoabril @enahum That's going to be quite the ticket. You might want to consider fixing this now rather than relying on that upgrade. |
@crspeller I’m with you but in any case I think we should downgrade the react-redux vs as is breaking current functionality and when upgrading again we should make sure everything works, there is no point in upgrading a dependency if we are not addressing the breaking changes. Then after the issues are fixed we could work on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I meant to approve. My comments are not blocking.
Thanks @crspeller @enahum. I added that comment to https://mattermost.atlassian.net/browse/MM-15040 |
Summary
Seems to be related to recent update of react-redux to v6.0.1 which might not be compatible with react-bootstrap@0.32.4 (per react-redux discussion).
I'd suggest to upgrade react-redux to v6/v7 once react-bootstrap releases the stable version of v1.
Ticket Link
Jira - MM-15039