This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14484 Remove download attribute from Open external image link #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
lieut-data
approved these changes
Apr 12, 2019
components/view_image/popover_bar/__snapshots__/popover_bar.test.jsx.snap
Show resolved
Hide resolved
crspeller
approved these changes
Apr 15, 2019
crspeller
added
4: Reviews Complete
lindy65
added
Tests/Not Needed
|
Can somebody help cherry pick this to v5.11? |
hanzei
pushed a commit
that referenced
this pull request
Apr 24, 2019
hanzei
added
4: Reviews Complete
amyblais
added
Changelog/Done
lindy65
removed
the
4: Reviews Complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser will attempt to download a linked file if that link has the download attribute. We were incorrectly specifying that attribute on a link that should just open an external image.
I'm not sure why this worked correctly (ie it just opened the file) for images that weren't served through the local image proxy, but it's possible it's some browser thing that prevents files from other domains from being downloaded this way.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14484