This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-14842] fix dismissing the tooltip when clicking the button #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonblais
added
1: PM Review
|
Tested on the spinmint and confirmed the issue on the Windows desktop app is fixed. Also tested on other environments to confirm it's still working as expected:
|
jasonblais
added
2: Dev Review
jasonblais
approved these changes
Apr 17, 2019
levb
approved these changes
Apr 17, 2019
crspeller
approved these changes
Apr 17, 2019
hanzei
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
lindy65
added
Tests/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes dismissing the tooltip when clicking the button a few times on the Windows desktop app. It was caused by a bug in older versions of Chromium and currently used in Electron. Sometimes a
clickevent fires amouseleaveevent. I saw that this "self-fired"mouseleaveevent has null in thetoElementproperty, so I just added a condition to hide the tooltip only if thetoElementproperty of themouseleaveevent is not null.Tested on the Windows Desktop app on 4.3 and now it works as expected. I also tested it on Safari, Mac Desktop App, Chrome and Firefox just for sure.
Ticket Link
Fixes mattermost/mattermost#10603