This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14456 Show search loading indicator until we have no more posts to load to avoid scroll pop #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
added
2: Dev Review
sudheerDev
reviewed
Apr 24, 2019
| @@ -2512,11 +2512,6 @@ | |||
| "regenerator-runtime": "^0.11.0" | |||
| }, | |||
| "dependencies": { | |||
| "core-js": { | |||
There was a problem hiding this comment.
Were these removed intentionally? Or npm did that?
There was a problem hiding this comment.
That was npm, not an intentional change by me
bradjcoughlin
approved these changes
Apr 24, 2019
jwilander
added a commit
that referenced
this pull request
Apr 25, 2019
… load to avoid scroll pop (#2684) * Show search loading indicator until we have no more posts to load to avoid scroll pop * Rename loading variable to be clearer * Update mattermost-redux
jwilander
added
CherryPick/Done
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show search loading indicator until we have no more posts to load to avoid scroll pop in the RHS when displaying search results.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14456