Webpack 4 compatible pdfjs-dist.

[silverskyvicto]

Summary

mattermost-webapp uses webpack 4, but pdfjs-dist 2.0.489 assumes webpack 2 or 3.

If it is the latest one, it supports webpack 4.

How about upgrading pdfjs-dist?

[saturninoabril]

@silverskyvicto Could you please check if this works for you? I'm getting error both on test server - link above and local dev.

[hmhealey]

Adding @grundleborg to this since he's been handling dependency updates lately.

[hmhealey]

The error that I'm seeing is that something is trying to run an eval statement which is blocked by CSP. I suppose that's why the stayed at the previous version of the library? According to mozilla/pdf.js#10229, it's caused by one of their dependencies (either Babel or facebook/regenerator), but as far as I know, we have newer versions of both of those dependencies.

[mattermod]

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

[cpanato]

removing the test server due stale, if need again please add the label back

[mattermod]

Test server destroyed

[mattermod]

We dont have permissions to update this PR, please contact the submitter to apply the update.

[hanzei]

/update-branch

[hmhealey]

Hi @silverskyvicto. Have you had a chance to look into the stuff we talked about above? Is there anything we could help with?

[silverskyvicto]

Hi @hmhealey

Sorry for the late reply.

I am also currently checking.
The query will close once, as it will take some time.

[hmhealey]

No worries. Let us know what you figure out!