This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-26305] migrate refs example #5753
Merged
Willyfrog
merged 3 commits into
mattermost:master
from
Willyfrog:MM-26305_migrate_refs_example
Jun 24, 2020
Merged
[MM-26305] migrate refs example #5753
Willyfrog
merged 3 commits into
mattermost:master
from
Willyfrog:MM-26305_migrate_refs_example
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Willyfrog
added
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Jun 18, 2020
Willyfrog
force-pushed
the
MM-26305_migrate_refs_example
branch
from
June 18, 2020 16:31
2692ca7
to
b853c3d
Compare
/update-branch |
hmhealey
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for an example, but in this case, the values that we're using are in this.state
, so do we even need refs here?
calebroseland
approved these changes
Jun 20, 2020
Willyfrog
changed the title
Mm 26305 migrate refs example
[MM-26305] migrate refs example
Jun 22, 2020
@hmhealey i'll create a second ticket for cleaninig this, but keep this one as example. |
/update-branch |
jgilliam17
added
Setup Cloud Test Server
Setup a test server using Mattermost Cloud
and removed
Setup Cloud Test Server
Setup a test server using Mattermost Cloud
labels
Jun 23, 2020
jgilliam17
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Willyfrog
Tested, looks good to merge.
- Verified password setting restrictions/rules in the admin console. No change in functionality.
jgilliam17
added
4: Reviews Complete
All reviewers have approved the pull request
and removed
3: QA Review
Requires review by a QA tester
Setup Cloud Test Server
Setup a test server using Mattermost Cloud
labels
Jun 23, 2020
Test server destroyed |
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Jun 24, 2020
This was referenced Sep 16, 2020
This was referenced Oct 5, 2020
Closed
This was referenced Oct 7, 2020
Closed
Closed
Closed
Closed
This was referenced Oct 7, 2020
This was referenced Oct 20, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the sample ticket for the migration campaign.
It migrates string refs for the checkbox defining password rules in the admin console.
Ticket Link
MM-26305