Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-26305] migrate refs example #5753

Merged
merged 3 commits into from
Jun 24, 2020

Conversation

Willyfrog
Copy link
Contributor

Summary

This is the sample ticket for the migration campaign.

It migrates string refs for the checkbox defining password rules in the admin console.

Ticket Link

MM-26305

@Willyfrog Willyfrog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jun 18, 2020
@Willyfrog Willyfrog force-pushed the MM-26305_migrate_refs_example branch from 2692ca7 to b853c3d Compare June 18, 2020 16:31
@Willyfrog
Copy link
Contributor Author

/update-branch

Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for an example, but in this case, the values that we're using are in this.state, so do we even need refs here?

@calebroseland calebroseland removed the 2: Dev Review Requires review by a core commiter label Jun 20, 2020
@Willyfrog Willyfrog changed the title Mm 26305 migrate refs example [MM-26305] migrate refs example Jun 22, 2020
@Willyfrog
Copy link
Contributor Author

Willyfrog commented Jun 22, 2020

This works for an example, but in this case, the values that we're using are in this.state, so do we even need refs here?

@hmhealey i'll create a second ticket for cleaninig this, but keep this one as example.

@Willyfrog
Copy link
Contributor Author

/update-branch

@jgilliam17 jgilliam17 added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 23, 2020
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Willyfrog
Tested, looks good to merge.

  • Verified password setting restrictions/rules in the admin console. No change in functionality.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jun 23, 2020
@mm-cloud-bot
Copy link

Test server destroyed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants