Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

migrate string-refs in user_list.jsx #6704

Merged
merged 7 commits into from
Nov 6, 2020
Merged

migrate string-refs in user_list.jsx #6704

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9ba113
migrate string-refs in user_list.jsx
VolatianaYuliana Oct 8, 2020
24dad52
Merge branch 'master' into MM-29086_migrate-strig-refs
mattermod Oct 13, 2020
37ecba4
Merge branch 'master' into MM-29086_migrate-strig-refs
mattermod Oct 13, 2020
4e6d583
Merge branch 'master' into MM-29086_migrate-strig-refs
mattermod Oct 20, 2020
3342f86
add unit test for user_list.jsx
VolatianaYuliana Nov 5, 2020
4e1c33e
remove the eslint-enable/disable comments + rename this.container
VolatianaYuliana Nov 5, 2020
479e622
Merge branch 'master' into MM-29086_migrate-strig-refs
mattermod Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions components/user_list.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@ export default class UserList extends React.PureComponent {
rowComponentType: UserListRow,
}

constructor(props) {
super(props);
this.container = React.createRef();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this to match what we are doing in other PRs

Suggested change
this.container = React.createRef();
this.containerRef = React.createRef();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay @Willyfrog

}

scrollToTop = () => {
if (this.refs.container) {
this.refs.container.scrollTop = 0;
if (this.container.current) {
this.container.current.scrollTop = 0;
}
}

Expand Down Expand Up @@ -80,7 +85,7 @@ export default class UserList extends React.PureComponent {
}

return (
<div ref='container'>
<div ref={this.container}>
{content}
</div>
);
Expand Down