This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-29684] Add check for isCloud to main_menu for displaying user_limit_modal #6792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmisasi
added
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Oct 14, 2020
/check-cla |
alifarooq0
approved these changes
Oct 15, 2020
marianunez
approved these changes
Oct 15, 2020
/update-branch |
nickmisasi
added
4: Reviews Complete
All reviewers have approved the pull request
and removed
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Oct 19, 2020
/cherry-pick cloud-ga |
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Oct 19, 2020
…attermost#6792) Co-authored-by: Mattermod <mattermod@users.noreply.github.com> (cherry picked from commit 65b0319)
mattermod
added
the
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
label
Oct 19, 2020
nickmisasi
added a commit
that referenced
this pull request
Oct 19, 2020
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Oct 19, 2020
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…6792) Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…6792) Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This check was missing on the user limit modal, which meant that on any license you would see the modal if the userlimit was non-zero.
Ticket Link
https://mattermost.atlassian.net/browse/MM-29684
Related Pull Requests
N/a
Screenshots
n/a