This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-29841] update class .header-dropdown__icon to use css variable #6862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @morganrconnolly, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
hanzei
added
2: Dev Review
asaadmahmood
approved these changes
Oct 22, 2020
hahmadia
approved these changes
Oct 22, 2020
hahmadia
added
3: QA Review
|
@lindalumitchell |
|
Thanks @hahmadia, I'm happy to take a look. Can you help me with what parts of the app this change should affect? I see |
|
Hey Linda, That should look the exact same and behave the same prior to these CSS changes. Thank you. |
lindalumitchell
added
the
Setup Cloud Test Server
lindalumitchell
approved these changes
Oct 27, 2020
lindalumitchell
added
4: Reviews Complete
hahmadia
removed
the
Setup Cloud Test Server
|
Test server destroyed |
hahmadia
merged commit b932d17
into
mattermost:campaign/applytheme_center-channel-color
amyblais
added
Changelog/Not Needed
deanwhillier
pushed a commit
that referenced
this pull request
Jan 26, 2021
deanwhillier
pushed a commit
that referenced
this pull request
Oct 27, 2021
# Conflicts: # sass/layout/_headers.scss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds css rule to
sass/layout/_headers.scssreplacingchangeCssoccurrence for.header-dropdown__iconcss classTicket Link
Fixes mattermost/mattermost#16027
Related Pull Requests
Screenshots