Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Conversation

1jz
Copy link

@1jz 1jz commented Oct 25, 2020

Summary

Removes the call to changeCss() for the disabled send button mentioned in the issue below and adjusts the buttons color to --center-channel-color to the scss file.

Ticket Link

Fixes mattermost/mattermost#16028

@mattermod
Copy link
Contributor

Hello @1jz,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hanzei
Copy link
Contributor

hanzei commented Oct 26, 2020

Hey @1jz, thanks for opening a PR! Would you be open on signing the contribution license agreement?

@1jz
Copy link
Author

1jz commented Oct 26, 2020

/check-cla

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label Oct 26, 2020
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for contributing

Copy link
Contributor

@nevyangelova nevyangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - 1 Minor conflict to resolve :)

@hanzei hanzei added Awaiting Submitter Action Blocked on the author 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 27, 2020
@1jz
Copy link
Author

1jz commented Oct 27, 2020

Conflict should be resolved, thank you for your patience :)

@1jz
Copy link
Author

1jz commented Oct 27, 2020

I didn't pay close attention and I ended up re-introducing one of the migrated calls in the last merge, it should be removed now.

@hanzei hanzei removed the Awaiting Submitter Action Blocked on the author label Oct 29, 2020
@hanzei hanzei merged commit 088f860 into mattermost:campaign/applytheme_center-channel-color Oct 29, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants