-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-29842] Migrate changeCSS() to CSS variable in utils/utils.jsx #6915
[MM-29842] Migrate changeCSS() to CSS variable in utils/utils.jsx #6915
Conversation
Hello @1jz, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
Hey @1jz, thanks for opening a PR! Would you be open on signing the contribution license agreement? |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for contributing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! - 1 Minor conflict to resolve :)
…/applytheme_center-channel-color
Conflict should be resolved, thank you for your patience :) |
I didn't pay close attention and I ended up re-introducing one of the migrated calls in the last merge, it should be removed now. |
Summary
Removes the call to
changeCss()
for the disabled send button mentioned in the issue below and adjusts the buttons color to--center-channel-color
to the scss file.Ticket Link
Fixes mattermost/mattermost#16028