Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations PR 20190422 #10670

Merged
merged 1 commit into from
Apr 23, 2019
Merged

translations PR 20190422 #10670

merged 1 commit into from
Apr 23, 2019

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Apr 22, 2019

Ideally this PR should be review by community members for each language.

Note: In the event that you see an english translation instead of the desired language is because this PR was submitted before the translation was made on the Mattermost Translation Server and probably will be submitted for the next PR.

Mobile PR: mattermost/mattermost-mobile#2734
Webapp PR: mattermost/mattermost-webapp#2688

Copy link
Contributor

@uhlhosting uhlhosting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ro.json LGTM

@jasonblais jasonblais requested a review from lieut-data April 22, 2019 22:54
@jasonblais jasonblais added the 2: Dev Review Requires review by a developer label Apr 22, 2019
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all greek to me, but otherwise looks good!

@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Apr 23, 2019
@enahum enahum merged commit 574e560 into release-5.11 Apr 23, 2019
@enahum enahum deleted the translations-20190422 branch April 23, 2019 01:47
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants