Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flipper-folly on iOS 14.5 #73

Merged
merged 1 commit into from
May 5, 2021
Merged

fix: flipper-folly on iOS 14.5 #73

merged 1 commit into from
May 5, 2021

Conversation

josephbaylon
Copy link
Contributor

Summary

After upgrading to Xcode 12.5/iOS 14.5, I'm not able to compile and install the NetworkClientExample iOS app anymore on simulator due to a Flipper-Folly issue. It looks like an open RN issue --> facebook/react-native#31179

I followed the first workaround here: https://stackoverflow.com/questions/67290697/react-native-0-64-wont-build-ios-app-after-updating-xcode-to-12-5-and-ios-to-14 and works for me locally.

Ticket Link

NA

@josephbaylon josephbaylon added the 2: Dev Review Requires review by a core committer label May 4, 2021
@josephbaylon josephbaylon requested review from migbot and enahum May 4, 2021 22:06
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be on the lookout to remove this once RN gets updated

@enahum enahum added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 5, 2021
@enahum enahum merged commit 3787cf8 into master May 5, 2021
@enahum enahum deleted the fix-flipper-folly branch May 5, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants