Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-57029] Multi-arch Docker images #148

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[MM-57029] Multi-arch Docker images #148

merged 1 commit into from
Jun 21, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Adding support for building and releasing multi-arch Docker images (amd64 and arm64).

Ticket Link

https://mattermost.atlassian.net/browse/MM-57029

@streamer45 streamer45 added 2: Dev Review Requires review by a core committer Do Not Merge / Awaiting load-test labels Jun 20, 2024
@streamer45 streamer45 added this to the v0.16.1 milestone Jun 20, 2024
@streamer45 streamer45 requested a review from cpoile June 20, 2024 14:26
@streamer45 streamer45 self-assigned this Jun 20, 2024
@streamer45
Copy link
Contributor Author

Sharing load-test results. I compared on a c7g.2xlarge instance against the two heaviest test cases we ran for c7i.2xlarge.

Overall comparable performance. To be noted, the Graviton instance comes at a 19% reduced on-demand cost and some extra bandwidth.

1000 calls, 2 participants per call, 2 unmuted, no screen sharing

Grafana

2% more CPU and 7% lower memory usage than base.

2 calls, 1000 participants per call, 1 unmuted, screen sharing

Grafana

2% more CPU and 5% lower memory usage than base.

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice results!

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 20, 2024
@streamer45
Copy link
Contributor Author

@stafot, once this gets in and we release it, we can consider using Graviton instances for our rtcd nodes.

@streamer45 streamer45 merged commit d27dcd9 into master Jun 21, 2024
2 checks passed
@streamer45 streamer45 deleted the MM-57029 branch June 21, 2024 07:18
@stafot
Copy link

stafot commented Jun 25, 2024

We will start adopt them soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants