[MM-45894] Allow signaling through data channel #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
cpoile
approved these changes
Sep 30, 2024
Merged
streamer45
added
3: Reviews Complete
* Implement data channel message type * Update client implementation * Update godeltaprof * Fix dc init race * [MM-60561] RTC client metrics (#159) * Client metrics * Implement rtc stats monitor * Remove unnecessary parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We take a similar approach to the one used for AV1 as we need to know if the client expects to use the DC for signaling. If that's the case, then other than for the very initial exchange (setting the DC itself), we default to the DC for any further signaling of media tracks.
To note, we purposely exclude ICE candidates from this logic since they are needed for the client to establish (or reestablish) connectivity, so they must require a side channel.
Related PRs
mattermost/calls-common#39
mattermost/mattermost-plugin-calls#865
Ticket Link
https://mattermost.atlassian.net/browse/MM-45894