issue #6 add xdebug host address and dns for host trhought internal n… #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonglasow
suggested changes
Mar 19, 2018
| echo "XDebug disabled"; | ||
| fi | ||
|
|
||
| if [ $REMOTE_HOST_ENABLE == "true" ]; then |
There was a problem hiding this comment.
Why configuring this variable if xdebug is disabled ?
There was a problem hiding this comment.
It's in case you need the DNS for the host for something else (no more need for the external_host with the ip of the host, you can use the docker internal network)
| @@ -10,6 +10,7 @@ RUN apt-get update -qq \ | |||
| && echo "zend_extension=$(find /usr/local/lib/php/extensions/ -name xdebug.so)" > /usr/local/etc/php/conf.d/xdebug.ini \ | |||
| && echo "xdebug.remote_enable=on" >> /usr/local/etc/php/conf.d/xdebug.ini \ | |||
| && echo "xdebug.remote_autostart=off" >> /usr/local/etc/php/conf.d/xdebug.ini \ | |||
| && echo "xdebug.remote_host=XDEBUG_REMOTE_HOST" >> /usr/local/etc/php/conf.d/xdebug.ini \ | |||
There was a problem hiding this comment.
As it's a specific configuration it's better to add a specific file like
ADD config/custom-php.ini /usr/local/etc/php/conf.d/custom-php.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add xdebug remote host through internal network to php config
Add remote_host DNS to host file