Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS support #33

Conversation

stonko1994
Copy link
Contributor

Description

This PR combines the following PRs:

+1

It also updates the podspec files to add visionOS support through CocoaPods.

@stonko1994 stonko1994 marked this pull request as ready for review November 2, 2023 10:59
@stonko1994
Copy link
Contributor Author

Before this update can be used in Nimble #34 also needs to be merged to fix Carthage support.

@stonko1994 stonko1994 mentioned this pull request Nov 2, 2023
4 tasks
@mattgallagher
Copy link
Owner

Sorry I've been a little slow to get to this. I'll try to look at these in the next day or two.

Copy link
Owner

@mattgallagher mattgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍. I'll run some double checks then update the versions.

@mattgallagher mattgallagher merged commit de14cf5 into mattgallagher:master Nov 11, 2023
@mattgallagher
Copy link
Owner

mattgallagher commented Nov 12, 2023

Okay, there's a new 2.2.0 tag so it should work via Swift Package Manager. I can't push an update to Cocoapods at the moment as the latest version of pod refuses to lint it:

[!] Invalid CwlPreconditionTesting.podspec file: undefined method `visionos' for #<Pod::Specification name="CwlPreconditionTesting">.

It looks like the "support" in 1.13 didn't really work and some additional changes will be needed to fully handle the new platform.

@stonko1994
Copy link
Contributor Author

Can you update without linting or specify the platforms to include?

I added --platforms="ios,tvos,watchos,macos" in Nimble to the pod lint command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants