Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SMTP imposters. #88

Merged
merged 6 commits into from
Apr 15, 2021
Merged

Support for SMTP imposters. #88

merged 6 commits into from
Apr 15, 2021

Conversation

adrianbontea
Copy link
Contributor

Note: Mountebank doesn't currently support stubs for SMTP imposters. (only mock verification)

@mattherman
Copy link
Owner

Thank you for the contribution! I don't have time to look through these changes right now, but I will try to get to it over the next few days.

@mattherman
Copy link
Owner

Apologies for the delay. I'm still planning on getting around to this soon.

Copy link
Owner

@mattherman mattherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and one explicit change.

MbDotNet/Models/Imposters/RetrievedSmtpImposter.cs Outdated Show resolved Hide resolved
MbDotNet/Models/Requests/SmtpRequest.cs Show resolved Hide resolved
MbDotNet/Models/Requests/SmtpRequest.cs Show resolved Hide resolved
@mattherman mattherman merged commit f334a7a into mattherman:master Apr 15, 2021
@mattherman
Copy link
Owner

A new package should be available shortly: https://www.nuget.org/packages/MbDotNet/5.0.0-rc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants