New methods #92
New methods #92
Conversation
|
I'm hoping to review this sometime this week. Apologies for the long turnaround. |
| /// </summary> | ||
|
|
||
| /// <returns>The list of logs</returns> | ||
| Task<List<Log>> GetLogsAsync(CancellationToken cancellationToken=default); |
There was a problem hiding this comment.
Update this to return Task<IEnumerable<Log>>
| /// </summary> | ||
| /// <returns>The list of retrieved imposters</returns> | ||
|
|
||
| Task<List<RetrievedImposters>> GetImpostersAsync(CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Update this to return Task<IEnumerable<RetrievedImposters>>
| @@ -15,5 +19,9 @@ internal interface IRequestProxy | |||
| Task<RetrievedHttpsImposter> GetHttpsImposterAsync(int port, CancellationToken cancellationToken = default); | |||
| Task<RetrievedSmtpImposter> GetSmtpImposterAsync(int port, CancellationToken cancellationToken = default); | |||
| Task DeleteSavedRequestsAsync(int port, CancellationToken cancellationToken = default); | |||
|
|
|||
| Task<List<RetrievedImposters>> GetImpostersAsync(CancellationToken cancellationToken = default); | |||
There was a problem hiding this comment.
Update this to return Task<IEnumerable<RetrievedImposters>>
|
|
||
| Task<List<RetrievedImposters>> GetImpostersAsync(CancellationToken cancellationToken = default); | ||
| Task<Home> GetEntryHypermediaAsync(CancellationToken cancellationToken = default); | ||
| Task<List<Log>> GetLogsAsync(CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Update this to return Task<IEnumerable<Log>>
|
|
||
|
|
||
| [JsonProperty("Timestamp")] | ||
| public string Timestamp { get; internal set; } |
There was a problem hiding this comment.
You should be able to make this a DateTime and it will deserialize it automatically.
| using (var response = await _httpClient.GetAsync("/logs", cancellationToken).ConfigureAwait(false)) | ||
| { | ||
| await HandleResponse(response, HttpStatusCode.OK, $"Failed to get the logs ", | ||
| (message) => new Exception(message)).ConfigureAwait(false); |
There was a problem hiding this comment.
Don't provide an exceptionFactory here. It will wrap it in a MountebankException by default.
| { | ||
|
|
||
| await HandleResponse(response, HttpStatusCode.OK, $"Failed to retrieve the list of imposters ", | ||
| (message) => new ImposterNotFoundException(message)).ConfigureAwait(false); |
There was a problem hiding this comment.
Don't provide an exceptionFactory here. ImposterNotFoundException is not really accurate for this request. Let it default to MountebankException.
|
|
||
| private async Task<List> GetImpostersAsync<List>(CancellationToken cancellationToken = default) | ||
| { | ||
| using (var response = await _httpClient.GetAsync($"{ImpostersResource}", cancellationToken).ConfigureAwait(false)) |
There was a problem hiding this comment.
I know it wasn't added by you, but could you delete and inline the ImpostersResource field? It's pretty unnecessary and using string literals in these methods lets you tie them back to the actual API more easily.
| await Client.DeleteAllImpostersAsync(); | ||
|
|
||
| Client.Imposters.Add(new HttpImposter(123, null)); | ||
| Client.Imposters.Add(new HttpImposter(456, null)); |
There was a problem hiding this comment.
This is not needed. All you need to do is setup the mock as you did below.
|
|
||
| var list=await _client.GetImpostersAsync(); | ||
|
|
||
| Assert.IsNotNull(list); |
There was a problem hiding this comment.
Please add an assert for the expected count.
|
These changes have been published in v5.0.0-rc8. |
Added a method to get the list of all imposters