remove wheeltools.py, import/require standalone wheeltools #46
Conversation
| cmp_contents, | ||
| open_readable, | ||
| open_rw, | ||
| chmod_perms, |
There was a problem hiding this comment.
@matthew-brett I kept these names in here as aliases for the functions that were moved out to the standalone wheeltools package. If you prefer, we can instead fix up all the relative .tools imports in delocate to instead import these from the wheeltools.tools.
| @@ -31,6 +31,7 @@ | |||
| "machomachomangler; sys_platform == 'win32'", | |||
| "bindepend; sys_platform == 'win32'", | |||
| "wheel", | |||
| "wheeltools >= 0.1.0b1", | |||
There was a problem hiding this comment.
we can just write wheeltools in install_requires, once we publish a stable release
|
Judging from the activity on auditwheel repo, and the lack of interest/feedback its maintainers showed for this splitting up and reuse of delocate’s wheeltools module in auditwheel, i think it’s not worth to proceed with this. Feel free to close this PR. |
|
Yes, sorry - I think the work involved is practical, but I can't do it at the moment, I am completely buried in work. For @ehashman - I still think this is the right way to go,and would add tests to a part of auditwheel that doesn't have them. |
|
I understand, no problem! |
|
So what is the status of this right now? It seems it hasn't been touched in years. |
|
I guess we could try again on the Auditwheel list to see if we can get more joint traction. |
as discussed in pypa/auditwheel#102
I published a pre-release version to PyPI so that we can try this out in delocate:
https://pypi.org/project/wheeltools/