Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctype included in output, even if it's not present in template #120

Closed
matthew-ia opened this issue Feb 3, 2023 · 0 comments
Closed

Doctype included in output, even if it's not present in template #120

matthew-ia opened this issue Feb 3, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
v.1.2.0

Comments

@matthew-ia
Copy link
Owner

<!DOCTYPE html> is always prepended to the output HTML.

To fix

This is either JSDOM or Vite. If it's JSDOM: Need to do the tag checks in prerender for Doctype, same as we do for html, body, etc.

If it's Vite, idk I guess post-processing before file-write, or let user fix in their own build scripts 😞
@matthew-ia matthew-ia added the bug Something isn't working label Feb 3, 2023
@matthew-ia matthew-ia changed the title Doctype included on output, even if it's not present in template Doctype included in output, even if it's not present in template Feb 3, 2023
@matthew-ia matthew-ia added this to the Next milestone May 7, 2023
matthew-ia added a commit that referenced this issue May 7, 2023
@matthew-ia
fix #120: prevent matching commented tags in prerender logic
2ab7584
matthew-ia added a commit that referenced this issue May 8, 2023
@matthew-ia
fixed #120, fixed #83: strips comments from template to avoid issues;…
6dadd99 
… etc.
@matthew-ia matthew-ia modified the milestones: Next, v.1.2.0 May 10, 2023
This was referenced Mar 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v.1.2.0
Development

No branches or pull requests
1 participant
@matthew-ia