Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Revise MANIFEST.in strategy to properly use prune #75

Merged
merged 5 commits into from
Aug 5, 2021

Conversation

matthewfeickert
Copy link
Owner

Resolves #73

Copy of scikit-hep/pyhf#1449

* Remove global exclude of dotfiles from MANIFEST.in to avoid potential problems with build systems
   - c.f. https://github.com/scikit-build/scikit-build/issues/537
* Use `prune **` to remove all files from the sdist
   - c.f. https://packaging.python.org/guides/using-manifest-in/#manifest-in-commands
   - "Setuptools also has undocumented support for ** matching zero or more characters including forward slash, backslash, and colon."
* Manually include all "default" files for a sdist in MANIFEST.in
   - c.f. https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist
* Add list of sdist contents to package publishing CI
   - Allow for easier checking of the sdist contents in CI logs

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #75 (6ac30ea) into main (ec5b039) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   25.21%   25.21%           
=======================================
  Files           7        7           
  Lines         238      238           
  Branches       38       38           
=======================================
  Hits           60       60           
  Misses        178      178           
Flag Coverage Δ
unittests 25.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5b039...6ac30ea. Read the comment docs.

@matthewfeickert matthewfeickert merged commit c8cdeb1 into main Aug 5, 2021
@matthewfeickert matthewfeickert deleted the build/fix-sdist branch August 5, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: Revise MANIFEST.in strategy
1 participant