fix(node): danger#1180 - Adjust tsconfig compiler options

Accidentally applied `es6` when compilerOptions.module was not defined.
matthewh · Jun 19, 2024 · c175fef · c175fef
1 parent c54a1fd
commit c175fef
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@
 ## Main
 
 <!-- Your comment below this -->
-
+- [#1180] Set module properly when tsconfig does not contain compilerOptions.module [@matthewh]
 <!-- Your comment above this -->
 
 ## 12.3.2

diff --git a/source/runner/runners/utils/transpiler.ts b/source/runner/runners/utils/transpiler.ts
@@ -149,10 +149,14 @@ const sanitizeTSConfig = (config: any, esm: boolean = false) => {
   //
   // @see https://github.com/apollographql/react-apollo/pull/1402#issuecomment-351810274
   //
-  if (!esm && safeConfig.compilerOptions.module) {
-    safeConfig.compilerOptions.module = "commonjs"
-  } else {
-    safeConfig.compilerOptions.module = "es6"
+  if (safeConfig.compilerOptions.module) {
+    if (!esm) {
+      // .ts files should fall back to commonjs
+      safeConfig.compilerOptions.module = "commonjs"
+    } else {
+      // .mts files must use `import`/`export` syntax
+      safeConfig.compilerOptions.module = "es6"
+    }
   }
 
   return safeConfig