Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Feature" request: consider removing colorize dependency #93

Closed
ragaskar opened this issue Aug 29, 2014 · 6 comments
Closed

"Feature" request: consider removing colorize dependency #93

ragaskar opened this issue Aug 29, 2014 · 6 comments

Comments

@ragaskar
Copy link

4247c42 pulls in the GPL-licensed colorize gem as a dependency. Some people working for companies with strict license policies may not be able to use capybara-screenshot at work as a result. Thought I'd mention it in case it's something you hadn't considered.

@mattheworiordan
Copy link
Owner

Is this an issue for you? I appreciate you highlighting this, but as of now, I have not had anyone say this was an issue. If it is, it could easily be substituted with simple colour encoding within the Gem itself.

@ragaskar
Copy link
Author

ragaskar commented Sep 3, 2014

Yes, sorry for being so vague, but this dependency does prevent us from using latest. We've locked to a version of the gem pre-colorize dependency, which is fine for now, but I imagine the next time we need updates we'll have to figure something out.

@mattheworiordan
Copy link
Owner

What about https://github.com/defunkt/colored/blob/master/LICENSE, if I swapped out that Gem would that work?

@ragaskar
Copy link
Author

ragaskar commented Sep 8, 2014

Yep, that's MIT, would be fine. Thanks for considering the change!

@mattheworiordan
Copy link
Owner

Ok, done, see https://rubygems.org/gems/capybara-screenshot and bd4519c

@ragaskar
Copy link
Author

ragaskar commented Sep 8, 2014

Thanks!

fbernier added a commit to fbernier/capybara-screenshot that referenced this issue Feb 17, 2015
mattheworiordan added a commit that referenced this issue Mar 8, 2015
#115, #93: Replaced colored gem depency with custom helper methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants