-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Feature" request: consider removing colorize dependency #93
Comments
Is this an issue for you? I appreciate you highlighting this, but as of now, I have not had anyone say this was an issue. If it is, it could easily be substituted with simple colour encoding within the Gem itself. |
Yes, sorry for being so vague, but this dependency does prevent us from using latest. We've locked to a version of the gem pre-colorize dependency, which is fine for now, but I imagine the next time we need updates we'll have to figure something out. |
What about https://github.com/defunkt/colored/blob/master/LICENSE, if I swapped out that Gem would that work? |
Yep, that's MIT, would be fine. Thanks for considering the change! |
Ok, done, see https://rubygems.org/gems/capybara-screenshot and bd4519c |
Thanks! |
… with custom helper methods
4247c42 pulls in the GPL-licensed colorize gem as a dependency. Some people working for companies with strict license policies may not be able to use capybara-screenshot at work as a result. Thought I'd mention it in case it's something you hadn't considered.
The text was updated successfully, but these errors were encountered: