Fix build issue #17
Closed
Fix build issue #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build did not work on latest version of "create astro".
```
"dependencies": {
"astro": "^2.0.2"
},
"devDependencies": {
"@matthewp/astro-fastify": "^2.0.3"
}
```
Issue origin: withastro/astro#5056
matthewp
reviewed
Feb 2, 2023
| @@ -117,7 +117,7 @@ export default function(options) { | |||
| } | |||
| } | |||
| }, | |||
| 'astro:build:start'({ buildConfig }) { | |||
| 'config.build'({ buildConfig }) { | |||
There was a problem hiding this comment.
this is not a real hook, what made you think to do this change?
There was a problem hiding this comment.
Check out the link I attached in original PR.
The deprecation of the buildConfig option in astro:build:start in favor of moving those same options to config.build.
It wont build using latest stable Astro version
There was a problem hiding this comment.
Ok. That is saying that the build is on the config.build object, not the config.build hook. I'll submit another PR to fix.
|
Published 2.1.1 which fixes this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build did not work on latest version of "create astro".
Here is the change that broke build.