Fix bug with attach-template and vars (#144)

* Fix bug with attach-template and vars * Adds a changeset
matthewp · Jul 8, 2022 · de0927e · de0927e
1 parent 3055dbe
commit de0927e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/.changeset/old-balloons-divide.md b/.changeset/old-balloons-divide.md
@@ -0,0 +1,5 @@
+---
+"corset": patch
+---
+
+Fix bug with attach-template and vars
diff --git a/src/render.js b/src/render.js
@@ -124,6 +124,7 @@ function render(element, bindings, root, changeset) {
     if(binding.dirty(changeset)) {
       /** @type {HTMLTemplateElement} */
       let result = binding.update(changeset);
+      if(Array.isArray(result)) result = result[0];
       let doc = element.ownerDocument || document;
       let frag = doc.importNode(result.content, true);
       element.replaceChildren(frag);

diff --git a/test/test-attach.js b/test/test-attach.js
@@ -45,4 +45,22 @@ QUnit.test('Restores the original value when there is no patch', assert => {
   assert.equal(app.firstChild.localName, 'span');
   template(false).update(root);
   assert.equal(app.firstChild.localName, 'strong');
+});
+
+QUnit.test('Can use a variable from another selector', assert => {
+  let root = document.createElement('main');
+  root.innerHTML = `<div id="app"></div>`;
+  let template = document.createElement('template');
+  template.innerHTML = `<div>works</div>`;
+  let bindings = sheet`
+    #app {
+      --template: ${template};
+      class-toggle: attached true;
+    }
+    .attached {
+      attach-template: var(--template);
+    }
+  `;
+  bindings.update(root);
+  assert.equal(root.firstElementChild.firstElementChild.textContent, 'works');
 });