You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A storage object, or a callable which returns a storage object. This handles the storage and retrieval of your files. See Managing files for details on how to provide this object.
But imagekit only accepts a storage object. It should supports a callable which returns a storage object for feature parity with django.
So rather than doing cachefile_storage=S3Boto3Storage(), one can just do cachefile_storage=S3Boto3Storage.
I've just been trying to use this fix and it looks like the change makes the storage callable - not the cachefile_storage. Or have I misunderstood something here?
Yeah, looks like it, I noticed it in our project too but I didn't submit a pull request, supposedly it should also check if cachefile_storage is callable.
But imagekit only accepts a storage object. It should supports a callable which returns a storage object for feature parity with django.
So rather than doing
cachefile_storage=S3Boto3Storage()
, one can just docachefile_storage=S3Boto3Storage
.django-imagekit/imagekit/cachefiles/__init__.py
Lines 43 to 45 in f6ed35f
The text was updated successfully, but these errors were encountered: