Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coveralls for testing code coverage #213

Closed
wants to merge 7 commits into from
Closed

Use coveralls for testing code coverage #213

wants to merge 7 commits into from

Conversation

saulshanabrook
Copy link
Contributor

You also have to go and add the repo on https://coveralls.io/

Then on every travis push, the code completion will be commented and you can see whether it rises or falls.

@matthewwithanm
Copy link
Owner

@saulshanabrook Why'd you close this?

@saulshanabrook saulshanabrook reopened this May 3, 2013
@saulshanabrook
Copy link
Contributor Author

Because I wasn't sure if coveralls works that well with tox. Normally, if you do all the different version through travis, then you can see the coverage for each different test run, like each different django and python version. So I wasn't sure how it would work, with tox just running all the different versions and then sending the coverage after all of that.

It would also be a separate possibility to maintain a tox.ini and a .travis.yml that both listed the build matrices. that way on travis they could all run in parallel, and you could see which version failed easier. but it is more redundant...

@matthewwithanm
Copy link
Owner

Hm. That's how we used to have it (redundant tox.ini and travis.yml) but I changed the travis.yml file to avoid the duplication and test entry points.

@bryanveloso Whatever you want to do here is fine with me.

@bryanveloso
Copy link
Collaborator

I do appreciate the work on here, but I'm honestly not a fan of Coverall's approach. Blame it on the fact that I'm a GitHubber, but I can't stand what they do to pull requests at the moment. :(

@saulshanabrook
Copy link
Contributor Author

Yeah its pretty terrible. I opened an issue a while ago about that, but no response yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants