Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new attribute 'IMAGEKIT_CACHE_TIMEOUT' #399

Closed
wants to merge 2 commits into from
Closed

Add new attribute 'IMAGEKIT_CACHE_TIMEOUT' #399

wants to merge 2 commits into from

Conversation

chrismaille
Copy link

In some projects the default timeout from caches are not very high - by choice or by Django default (5 minutes).

I believe this new attribute can give more control on default timeout behavior for imagekit.

Thank you for the time evaluating this PR.

@vstoykov
Copy link
Collaborator

Hello @chrismaille and thank you for your contribution.

In the past there was a discussion between me and the owner of the project about such settings. My opinion was that there should be such a settings and not relying on IMAGEKIT_CACHE_BACKEND, because you can use the same backend but just use different timeouts.

As I see now I'm not the only person who thinks that this something that developers wants.

My only concern about your PR is that you need to move the config in imgekit.conf (https://github.com/chrismaille/django-imagekit/blob/develop/imagekit/conf.py) with some default and use it from there.

@vstoykov vstoykov mentioned this pull request Feb 8, 2017
@vstoykov
Copy link
Collaborator

vstoykov commented Feb 8, 2017

Hi @chrismaille because you are not interested in your PR, I've started a new one which will also introduce 1 day cache by default. If you wan you can look at it in #403 and tell your opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants