Improved docs to include example on how to use plain ImageSpec (defin… #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed outside of model, not ImageSpecField) with AdminThumbnail.
vstoykov
reviewed
May 5, 2017
README.rst
Outdated
| format = 'JPEG' | ||
| options = {'quality': 60 } | ||
|
|
||
| def cached_admin_thumb(model): |
There was a problem hiding this comment.
I think that model is a confusing name for this variable because the actual instance will be passed here.
… outside of models.
|
OK, changed it. |
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed outside of model, not ImageSpecField) with AdminThumbnail.
I hope this is the cleanest way of doing that?