Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure paragraph start tags begin a paragraph #108

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mirabilos
Copy link

Fixes #92 and is the only remaining code change I have (as opposed to wrapping Markdownify)

@AlexVonB
Copy link
Collaborator

Hi! This breaks some working code, as there will be a few places with loads of empty lines, for example:

md('<blockquote><p>Hello</p><p>Hello again</p></blockquote>')


       > Hello
       > 
       > 
       > 
       > Hello again

@mirabilos
Copy link
Author

mirabilos commented Mar 26, 2024 via email

jsm28 added a commit to jsm28/python-markdownify that referenced this pull request Apr 9, 2024
There are various cases in which inline text fails to be separated by
(sufficiently many) newlines from adjacent block content.  A paragraph
needs a blank line (two newlines) separating it from prior text, as
does an underlined header; an ATX header needs a single newline
separating it from prior text.  A list needs at least one newline
separating it from prior text, but in general two newlines (for an
ordered list starting other than at 1, which will only be recognized
given a blank line before).

To avoid accumulation of more newlines than necessary, take care when
concatenating the results of converting consecutive tags to remove
redundant newlines (keeping the greater of the number ending the prior
text and the number starting the subsequent text).

This is thus an alternative to matthewwithanm#108 that tries to avoid the excess
newline accumulation that was a concern there, as well as fixing more
cases than just paragraphs, and updating tests.

Fixes matthewwithanm#92

Fixes matthewwithanm#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline <p> not handled well
2 participants