Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Removing the currently playing song stops the jukebox completely #53

Closed
PaulDance opened this issue May 14, 2019 · 3 comments
Closed

Removing the currently playing song stops the jukebox completely #53

PaulDance opened this issue May 14, 2019 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@PaulDance
Copy link

PaulDance commented May 14, 2019

When removing the currently playing song from the jukebox using the corresponding black cross button, the entry is removed yes, but firstly the song does not really stop:

capture-2

and secondly also, the entire server seems to simply exit without any error message:

capture-3

while the youtube embeded video still runs and is still interactive but without any sound produced though.

@matthias4217
Copy link
Owner

I can reproduce it yes. There was a nasty segfault (#43) that I thought I had fixed. I guess it's back !
The embedded video is loaded client-side, so it will stay no matter what the server status is.

@matthias4217 matthias4217 added the bug Something isn't working label May 15, 2019
@matthias4217 matthias4217 added this to the MkIII-v1.0 milestone May 15, 2019
@PaulDance
Copy link
Author

The embedded video is loaded client-side, so it will stay no matter what the server status is.

Don't you think having a client-side embedded video messes things up a bit ? Because from my experience using the jukebox so far, it's a bit confusing and adds instability to the whole functionality ?

matthias4217 added a commit that referenced this issue May 15, 2019
@matthias4217
Copy link
Owner

The client-side part is quite separate from the rest, and is managed with JQuery and Youtube iframe API. We only fetch the current video ID and and time of the mpv progression to sync the video. Thus I don't think it is too much of a problem. I'm not the strongest proponent for this solution but other people do want to see a video. Most of the instability is caused server-side by my usage of flask, sorry.
Normally latest version mkIII-0.6.9 should be stable enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants