fix: improve TimeProvider and fix formatting for durations between one and two days #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in getEndOfWeek falsely returning sunday 00:00 instead of monday 00:00 (half-open approach). Remove offset parameters from TimeProvider methods to simplify testing. Offsets can easily be applied on the returned ZonedDateTime by using the functions plusDays(), plusWeeks(), etc.. Add extensive tests for TimeProvider.
…thly goals starting at the beginning of the week and month respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in getDurationString where a duration between one and two days would be formatted to the number of hours left in the day.
Ensure that weekly and monthly goals created by prepopulateDatabase() correctly start at the beginning of the week/month.
Remove offset parameters from TimeProvider methods to simplify testing. Offsets can easily be applied on the returned ZonedDateTime by using the functions plusDays(), plusWeeks(), etc..
Add extensive unit tests for TimeProvider.
Reverse order of "last five goals" in statistics.
Closes #78 and #79.