Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v3 #53

Merged
merged 14 commits into from
Feb 27, 2024
Merged

API v3 #53

merged 14 commits into from
Feb 27, 2024

Conversation

matthiasgomolka
Copy link
Owner

As mentioned in #51, the new API V3 is now mandatory. This PR accomodates for the respecting changes. This is a rather rough PR since not all features are fully tested and there might be other smaller issues.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 25.20000% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 20.44%. Comparing base (39c0de7) to head (8b3c49e).

Files Patch % Lines
R/sfa_load_statement.R 0.00% 53 Missing ⚠️
R/sfa_load_shareprices.R 0.00% 48 Missing ⚠️
R/utils.R 6.97% 40 Missing ⚠️
R/sfa_load__shares_outstanding.R 0.00% 35 Missing ⚠️
R/check_inputs.R 10.00% 9 Missing ⚠️
R/zzz.R 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
- Coverage   92.71%   20.44%   -72.28%     
===========================================
  Files          13       10        -3     
  Lines         508      318      -190     
===========================================
- Hits          471       65      -406     
- Misses         37      253      +216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthiasgomolka matthiasgomolka merged commit 30f09f0 into main Feb 27, 2024
6 of 8 checks passed
@matthiasgomolka matthiasgomolka deleted the api_v3 branch March 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant