Skip to content

Commit

Permalink
Rollup merge of rust-lang#99724 - ehuss:fix-broken-links-fragment, r=…
Browse files Browse the repository at this point in the history
…Dylan-DPC

Fix some broken link fragments.

An exception for link fragments starting with `-` was added in rust-lang#49590. However, it is not clear what issues were encountered at the time. Perhaps those were fixed in the meantime.

This removes the exception, and fixes a couple of broken links that were skipped due to it.
  • Loading branch information
matthiaskrgr authored Jul 26, 2022
2 parents ea299e8 + 91599b4 commit dfaf6ec
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/doc/rustdoc/src/deprecated-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ change in any release.

In the past the most common use case for customizing passes was to omit the `strip-private` pass.
You can do this more easily, and without risk of the pass being changed, by passing
[`--document-private-items`](./unstable-features.md#--document-private-items).
[`--document-private-items`](command-line-arguments.md#--document-private-items-show-items-that-are-not-public).
2 changes: 1 addition & 1 deletion src/doc/rustdoc/src/unstable-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ Note that the third item is the crate root, which in this case is undocumented.
and is also accepted on stable toolchains.

It can also be used with `--show-coverage`. Take a look at its
[documentation](#--show-coverage-get-statistics-about-code-documentation-coverage) for more
[documentation](#--show-coverage-calculate-the-percentage-of-items-with-documentation) for more
information.

### `--enable-per-target-ignores`: allow `ignore-foo` style filters for doctests
Expand Down
5 changes: 0 additions & 5 deletions src/tools/linkchecker/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,6 @@ impl Checker {
return;
}

// These appear to be broken in mdbook right now?
if fragment.starts_with('-') {
return;
}

parse_ids(&mut target_ids.borrow_mut(), &pretty_path, target_source, report);

if target_ids.borrow().contains(*fragment) {
Expand Down

0 comments on commit dfaf6ec

Please sign in to comment.