Add tests for PHP8.4 and report error thoroughly

.github/workflows/test.yml

@@ -16,6 +16,8 @@ jobs:
           curl -L "https://github.com/docker/compose/releases/latest/download/docker-compose-$(uname -s | tr '[:upper:]' '[:lower:]')-$(uname -m)" -o docker-compose
           chmod +x docker-compose
           mv docker-compose /usr/local/bin/docker-compose
+      - name: Test PHP 8.4
+        run: make test PHP=8.4
       - name: Test PHP 8.3
         run: make test PHP=8.3
       - name: Test PHP 8.2

CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 
 
+## [1.5.4] - 2024-12-20
+### Fixed
+- Fixed PHP 8.4 deprecation of implicit nullable parameters
+
+
 ## [1.5.3] - 2024-04-02
 ### Fixed
 - Fixed Redis TLL override on failure to add key
@@ -358,3 +363,4 @@
 [1.5.1]: https://github.com/matthiasmullie/scrapbook/compare/1.5.0...1.5.1
 [1.5.2]: https://github.com/matthiasmullie/scrapbook/compare/1.5.1...1.5.2
 [1.5.3]: https://github.com/matthiasmullie/scrapbook/compare/1.5.2...1.5.3
+[1.5.4]: https://github.com/matthiasmullie/scrapbook/compare/1.5.3...1.5.4

Dockerfile

@@ -4,4 +4,6 @@ FROM php:$version
 WORKDIR /var/www
 COPY . .
 
+RUN mv "$PHP_INI_DIR/php.ini-development" "$PHP_INI_DIR/php.ini"
+
 RUN docker/php.sh

docker-compose.yml

@@ -8,6 +8,10 @@ services:
       dockerfile: Dockerfile
       args:
         version: cli
+    volumes:
+      - ./src:/var/www/src
+      - ./tests:/var/www/tests
+      - ./phpunit.xml:/var/www/phpunit.xml
   php-8.1:
     <<: *default-php
     build:
@@ -26,6 +30,12 @@ services:
       <<: *default-php-build
       args:
         version: 8.3-cli
+  php-8.4:
+    <<: *default-php
+    build:
+      <<: *default-php-build
+      args:
+        version: 8.4.0RC3-cli-bookworm
   couchbase:
     build:
       context: .

makefile

@@ -43,7 +43,7 @@ test:
 	RELEVANT_CONTAINERS="$$TEST_CONTAINER $(filter-out apc flysystem memorystore sqlite, $(shell echo $(ADAPTER) | tr 'A-Z,' 'a-z '))";\
 	docker-compose up --no-deps --wait -d $$DEPENDENT_CONTAINERS;\
 	GROUP_ARRAY=($$(echo "$(GROUP)" | tr "," "\n"));\
-	docker-compose run --no-deps $$VOLUMES $$TEST_CONTAINER env XDEBUG_MODE=coverage vendor/bin/phpunit $${GROUP_ARRAY[@]/#/--group } --testsuite $(ADAPTER) --coverage-clover build/coverage-$(PHP)-$(ADAPTER).clover;\
+	docker-compose run --no-deps $$VOLUMES $$TEST_CONTAINER env XDEBUG_MODE=coverage vendor/bin/phpunit $${GROUP_ARRAY[@]/#/--group } --testsuite $(ADAPTER) --coverage-clover build/coverage-$(PHP)-$(ADAPTER).clover --configuration=phpunit.xml;\
 	TEST_STATUS=$$?;\
 	docker-compose stop -t0 $$RELEVANT_CONTAINERS;\
 	exit $$TEST_STATUS

phpunit.xml

@@ -1,5 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" bootstrap="tests/bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd">
+<phpunit
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  colors="true"
+  bootstrap="tests/bootstrap.php"
+  displayDetailsOnTestsThatTriggerDeprecations="true"
+  displayDetailsOnTestsThatTriggerErrors="true"
+  displayDetailsOnTestsThatTriggerNotices="true"
+  displayDetailsOnTestsThatTriggerWarnings="true"
+  xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd"
+>
   <coverage>
     <report>
       <clover outputFile="build/coverage.clover"/>