-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the library phpunit 10 compatible #15
Make the library phpunit 10 compatible #15
Conversation
Since phpunit 10.4 the toString method is called when sending out events, so it needs to be implemented now.
Thanks, looks good. The CI still needs fixing: https://github.com/matthiasnoback/phpunit-asynchronicity/blob/master/.github/workflows/code_analysis.yaml Can you look into that? |
Since phpunit 10.4 the toString method is called when sending out events, so it needs to be implemented now.
3567d93
to
dea0951
Compare
Looks like tuffz has already beaten me to it: #17 :) |
…ons' into update_library
Okay, shall we go with that PR then? |
I'm actually fixing the phpstan warnings that were ignored there, give me a sec, than we can merge it a cleaner state 👍 |
It should be all green now. I've included the fixes from stuffz and my additional ones to resolve the new warnings :) As I can't run the workflow in this repo I'm not 100% sure, but it's all green on my machine 😅 |
Thanks, released as v3.0.0 |
Thanks! 🥳 |
Great teamwork 🤝 |
Since phpunit 10.4 the toString() method is called when sending out events. This causes any test to fail with the 'NotImplementedException', so it needs to be implemented now.
It would be nice if we can tag this as version 3.
Here is a little snippet of the stacktrace with the new phpunit where you can see that the event trigger is causing the toString() to be called: