Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create temp directory if it does not exists #9

Merged
merged 2 commits into from
Apr 22, 2019

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Oct 10, 2017

create temp directory if it does not exists

fixes fsprojects/FAKE#1707

create temp directory if it does not exists

fixes fsprojects/FAKE#1707
@matthid
Copy link
Owner

matthid commented Oct 15, 2017

I'm not sure if we should just create it. I mean the tmp folder should always exist usually. No idea what you are doing ;). However, I don't mind checking (and therefore improving the error message).
We might consider to throw an IOException just like Path.

@0x53A
Copy link
Contributor Author

0x53A commented Oct 16, 2017

Yeah you are probably right ...

A few versions ago, it did work (I guess fake just didn't access temp at all) , and I got really frustrated after wasting so much time looking for a "stupid" issue, but I guess you are right that the temp folder should always exist ...

Will follow your recommendation and throw an ioexception with an explicit message "temp does not exist".

@matthid
Copy link
Owner

matthid commented Oct 16, 2017

Maybe even include the path "temp '%s' does not exist" this might make it easier for people to figure out where the invalid path is coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fake fails with unhelpful error if %temp% does not exist
2 participants