Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AU915 bandwidth and Adafruit Feather LoRa Boards #174

Closed
wants to merge 3 commits into from

Conversation

testert1ng
Copy link

@testert1ng testert1ng commented May 15, 2018

Extend most of the US915 configurations, changed frequencies for TX and RX.

Extend most of the US915 configurations, changed frequencies for TX and
RX.
Copy link

@StereotypicalSquirrel StereotypicalSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully tested this merge on an Adafruit Adafruit Feather M0 RFM95 LoRa on AU915. ABP and OTAA both work with TTN.

I recommend the following changes:

  1. Line 239 has a typo (Adfruit).
  2. Line 249 has a typo (boadr).
  3. Add either a pinmap or a comment for the Adfruit Feather M0 RFM95.

Correct pinmap for the M0 version is (Only difference is that DIO0 changes to pin 3):

Adafruit Feather M0 RFM95W loRa Radio 900MHz

This board uses the following pin mapping:

const lmic_pinmap lmic_pins = {
	.nss = 8,
	.rxtx = LMIC_UNUSED_PIN,
	.rst = 4,
	.dio = {3, 6, LMIC_UNUSED_PIN},
};

PIN6 and IO1 from the Adafruit board need to be connected before uploading the code.

Thanks

@testert1ng
Copy link
Author

@StereotypicalSquirrel Thanks for your suggestion.

I have fixed the problems and added M0 pin map.

@testert1ng testert1ng changed the title Add AU915 bandwidth and Adafruit Feather32u4 LoRa Board Add AU915 bandwidth and Adafruit Feather LoRa Boards Jul 5, 2018
@ElectronicallyE
Copy link

ElectronicallyE commented Jan 9, 2019

Could this please be merged @StereotypicalSquirrel or @matthijskooijman? I've been using this branch as my primary library for over two months and it works perfectly with no issues. Being in Australia, the standard library does not work for AU915, meaning I have had to resort to using the code by @testerting.

@matthijskooijman
Copy link
Owner

This repository is now deprecated, see #297 for some more background. I'm grateful for your contribution, but it will no longer be merged. I'm recommending people to use the MCCI version of LMIC instead. If this PR addresses an issue that also exists in that version, I would encourage you to resubmit your contribution there, so it might benefit other users. I'm sorry for the inconvenience...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants