Resolve issue exporting & importing booleans #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aryehraber Exporting works great! However, I'm having trouble importing falsy values. For example, I have a toggle on a page which is currently enabled, I export and change the value from |
|
@mattias-persson Thanks for testing and the feedback -- can definitely take another look! Before I do, just want to double check: did you check the translated version for the toggle change or the original? I kept making this mistake while testing 🙈 |
|
@aryehraber Pretty sure I tried both! When only changing the |
|
@mattias-persson Cool, thanks for confirming. Will run some more tests later this week and report back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles #11 by casting booleans as strings during export, and then back to booleans during import.
Let me know if you have any questions!