Improve validation errors in mixin #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjamaan
force-pushed
the
better-validation-errors
branch
2 times, most recently
from
722f217
to
196fb22
Compare
added 3 commits
July 22, 2019 13:31
This improves things in the following ways: - The exception object contains a key to indicate which field is causing the problem. - The exception object contains a "code"/slug which can be used to programmatically deal with the error. Very useful in JSON APIs. - We now use a standard text message that is more in line with the rest of Django (which also means it is translatable)
Just like Django will do in the standard behaviour, we want to ensure all errors are included. Therefore, we catch validation errors raised by Django and merge these with our own.
Instead, evaluate the validation of every unique index.
sjamaan
force-pushed
the
better-validation-errors
branch
from
196fb22
to
042819e
Compare
|
Why no feedback on this PR? I'm relying on this code in production, and it's essential for us, in case you're doubting the use of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has several improvements to how validation errors are raised by the mixin:
codefield is very useful to determine what is wrong with that particular field, and we rely on this in our project at workThis builds on #15 so please take a look at that one first.